Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-add circleci artifact fetching #76

Merged
merged 2 commits into from
Mar 7, 2024
Merged

re-add circleci artifact fetching #76

merged 2 commits into from
Mar 7, 2024

Conversation

aliciaaevans
Copy link
Contributor

Re-added CircleCI artifact fetching for linux-aarch64 builds.

  • This will not include the docker images built by CircleCI, but the code is there only one line needs to be modified to include *.tar.gz.
  • I kept the comment format for CircleCI that was in the previous version because the artifacts are downloadable individually, not as a zip.
  • If there are no CircleCI artifacts, that section will not be included at all. (If there are no Azure artifacts, there is a message suggesting possible problems.)
  • I saw here that the merge functionality is disabled, so I did not do anything to support CircleCI there.

Sample comment for PR bioconda/bioconda-recipes#46173

Azure

Package(s) built on Azure are ready for inspection:

Arch Package Zip File
linux-64 spacepharer-5.c2e680a-pl5321h6a68c12_4.tar.bz2 LinuxArtifacts
osx-64 spacepharer-5.c2e680a-pl5321hf590d3d_4.tar.bz2 OSXArtifacts

You may also use conda to install these after downloading and extracting the appropriate zip file. From the LinuxArtifacts or OSXArtifacts directories:

conda install -c ./packages <package name>

Docker image(s) built (images for Azure are in the LinuxArtifacts zip file above):

Package Tag Install with docker
spacepharer 5.c2e680a--pl5321h6a68c12_4
showgzip -dc LinuxArtifacts/images/spacepharer:5.c2e680a--pl5321h6a68c12_4.tar.gz | docker load

CircleCI

Package(s) built on CircleCI are ready for inspection:

Arch Package Repodata
linux-aarch64 spacepharer-5.c2e680a-pl5321h76f4f2e_4.tar.bz2 repodata.json

You may also use conda to install these:

conda install -c https://output.circle-artifacts.com/output/job/32f2bc5a-2105-432e-a955-569c1f5ed4e6/artifacts/0/tmp/artifacts/packages <package name>

@aliciaaevans aliciaaevans requested review from daler and mbargull March 7, 2024 18:01
@aliciaaevans aliciaaevans linked an issue Mar 7, 2024 that may be closed by this pull request
Re-add CircleCI artifact fetching #62
Closed
@aliciaaevans
Copy link
Contributor Author

found one scenario with an error, fixing now.

@aliciaaevans
Copy link
Contributor Author

OK, fixed the scenario of missing Azure builds.

@daler
Copy link
Member

daler commented Mar 7, 2024

Awesome. Merge when ready!

@aliciaaevans aliciaaevans merged commit ecfb6b5 into main Mar 7, 2024
4 checks passed
martin-g
martin-g reviewed Mar 8, 2024
View reviewed changes
images/bot/src/bioconda_bot/comment.py
comment = compose_azure_comment(artifacts["azure"] if "azure" in artifacts else [])
if len(comment) > 0:
comment += "\n\n"
comment += compose_circlci_comment(artifacts["circleci"] if "circleci" in artifacts else [])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: compose_circleci_comment

@aliciaaevans aliciaaevans mentioned this pull request Mar 26, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-g martin-g martin-g left review comments

@daler daler daler approved these changes

@mbargull mbargull Awaiting requested review from mbargull

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-add CircleCI artifact fetching
3 participants
@aliciaaevans @daler @martin-g